fix(cloudformation-include): string arrays inside unknown properties cannot be parsed #32461
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
otaviomacedo
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32461 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
=======================================
Hits 5694 5694
Misses 1357 1357
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-maintainer-review
otaviomacedo
changed the title
| "NonExistentResourceAttribute": "Bucket1" | ||
| "ResourceSignal": { | ||
| "Count": 1, | ||
| "Timeout": "PT10M" | ||
| } |
There was a problem hiding this comment.
Why are we renaming properties in a file called non-existent-policy-attribute.json away from a nonexistent name to a recognized name? This looks like it's removing a test for a specific behavior.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio refresh |
✅ Pull request refreshed |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
We are using
thisto refer to static methods, which fails at runtime. Use the class name instead.Fixes #32454.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license